Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added evidence option for ban and tempban #114

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

janssensjelle
Copy link
Contributor

@janssensjelle janssensjelle commented Nov 12, 2024

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This PR will add an optional field evidence (Requested in issue #45) where the moderator can add a link to the evidence. A note will be added with each action containing the linked evidence. If none is provided, the text will be "none provided".

Examples:
Screenshot 2024-11-12 at 20 15 04

Moderators/staff should be made aware of this change. This would mean that a /note add is no longer required.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Screenshot 2024-11-13 at 15 14 54 Screenshot 2024-11-13 at 15 14 58

Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
@janssensjelle janssensjelle changed the title Added evidence option for ban and tempban [FEATURE] Added evidence option for ban and tempban Nov 12, 2024
@janssensjelle janssensjelle marked this pull request as ready for review November 13, 2024 14:28
Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
@0xEmma
Copy link
Collaborator

0xEmma commented Nov 13, 2024

lgtm

Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work!

@dimoschi dimoschi merged commit 4b3bfff into hackthebox:main Nov 13, 2024
@janssensjelle janssensjelle deleted the feature/evidence-for-bans branch November 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants